Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo clean up #4515

Closed
chilling opened this issue Dec 19, 2013 · 0 comments · Fixed by #4580
Closed

Geo clean up #4515

chilling opened this issue Dec 19, 2013 · 0 comments · Fixed by #4580

Comments

@chilling
Copy link
Contributor

The default unit for measuring distances is MILES in most cases. ES should move over to the International System of Units and return METERS by default and internally work on a default unit.
If the internal measurement of explicitly changes to a default unit. DistanceUnit.DEFAULT which should relate to meters will also effect the REST API at the following places:

  • ScriptDocValues.factorDistance() returns meters instead of miles
  • ScriptDocValues.factorDistanceWithDefault() returns meters instead of miles
  • ScriptDocValues.arcDistance() returns meters instead of miles
    one might use ScriptDocValues.arcDistanceInMiles()
  • ScriptDocValues.arcDistanceWithDefault() returns meters instead of miles
  • ScriptDocValues.distance() returns meters instead of miles
    one might use ScriptDocValues.distanceInMiles()
  • ScriptDocValues.distanceWithDefault() returns meters instead of miles
    one might use ScriptDocValues.distanceInMilesWithDefault()
  • GeoDistanceFilter default unit changes from kilometers to meters
  • GeoDistanceRangeFilter default unit changes from miles to meters
  • GeoDistanceFacet default unit changes from miles to meters

The naming of the GeoBoundingBoxFilter properties should allow to set the opposite corners (see #4084) namely top_right and bottom_left. This change also includes the fields topRight and bottomLeft. Also it should be possible to set the single values by using just top, bottom, left and right parameters.

@ghost ghost assigned chilling Jan 2, 2014
@chilling chilling mentioned this issue Jan 2, 2014
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
============
The default unit for measuring distances is *MILES* in most cases. This commit moves ES
over to the *International System of Units* and make it work on a default which relates
to *METERS* . Also the current structures of the `GeoBoundingBox Filter` changed in
order to define the *Bounding* by setting abitrary corners.

Distances
---------
Since the default unit for measuring distances has changed to a default unit
`DistanceUnit.DEFAULT` relating to *meters*, the **REST API** has changed at the
following places:

  * `ScriptDocValues.factorDistance()` returns *meters* instead of *miles*
  * `ScriptDocValues.factorDistanceWithDefault()` returns *meters* instead of *miles*
  * `ScriptDocValues.arcDistance()` returns *meters* instead of *miles*
        one might use `ScriptDocValues.arcDistanceInMiles()`
  * `ScriptDocValues.arcDistanceWithDefault()` returns *meters* instead of *miles*
  * `ScriptDocValues.distance()` returns *meters* instead of *miles*
        one might use `ScriptDocValues.distanceInMiles()`
  * `ScriptDocValues.distanceWithDefault()` returns *meters* instead of *miles*
        one might use `ScriptDocValues.distanceInMilesWithDefault()`
  * `GeoDistanceFilter` default unit changes from *kilometers* to *meters*
  * `GeoDistanceRangeFilter` default unit changes from *miles* to *meters*
  * `GeoDistanceFacet` default unit changes from *miles* to *meters*

Geo Bounding Box Filter
-----------------------
The naming of the GeoBoundingBoxFilter properties allows to set arbitrary corners
(see elastic#4084) namely `top_right`, `top_left`, `bottom_right` and `bottom_left`. This
change also includes the fields `topRight` and `bottomLeft` Also it is be possible to
set the single values by using just `top`, `bottom`, `left` and `right` parameters.

Closes elastic#4515, elastic#4084
@chilling chilling removed their assignment Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant